Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle flatpage #1078

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Restyle flatpage #1078

merged 6 commits into from
Apr 2, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Apr 2, 2024

  • New style for flatPage
  • Add suggestions from GTA's WYSIWYG

@dtrucs dtrucs requested a review from a team April 2, 2024 13:55
@dtrucs dtrucs force-pushed the Restyle-flatpage branch from f12831e to c075c7b Compare April 2, 2024 14:45
Bo-Duke
Bo-Duke approved these changes Apr 2, 2024
View reviewed changes
frontend/src/components/pages/flatPage/useFlatPage.tsx
const suggestions = getSuggestionsFromContent(flatPage?.content ?? '');

const activitySuggestionIds = suggestions.flatMap(suggestion =>
'ids' in suggestion ? suggestion.ids : [suggestion.type],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'ids' in suggestion ? suggestion.ids : [suggestion.type],
suggestion.ids ?? [suggestion.type],

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My code is a bit tricky because I have a little problem with the suggestion type, which thinks ids doesn't exist, but it does. 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the suggestion 🙏

@dtrucs dtrucs merged commit c31964a into develop Apr 2, 2024
2 checks passed
@dtrucs dtrucs deleted the Restyle-flatpage branch April 2, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo-Duke Bo-Duke Bo-Duke approved these changes

@mabhub mabhub mabhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtrucs @mabhub @Bo-Duke